From 1adfabf512ef93e1cf941f0b9bf25d9f76e6a14f Mon Sep 17 00:00:00 2001 From: Shane Engelman Date: Fri, 16 Sep 2022 13:12:28 -0700 Subject: [PATCH] Pass Android parameters for Windows builds, fixes #434 (#436) https://github.com/game-ci/unity-builder/issues/434 will show that no Windows builds are currently capable of sending `androidVersionCode` or any other Android parameters. This can be fixed very simply by adjusting the build script to pass these parameters. Compare the following two files: - https://github.com/game-ci/unity-builder/blob/cdee7d1d9a8ab9eccc408a37832b43d6afa73507/dist/platforms/windows/build.ps1#L112 - https://github.com/game-ci/unity-builder/blob/cdee7d1d9a8ab9eccc408a37832b43d6afa73507/dist/platforms/ubuntu/steps/build.sh#L138 It's clear that the current Windows build script is omitting certain parameters. This will resolve that issue (linked in commit message header). --- dist/platforms/windows/build.ps1 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dist/platforms/windows/build.ps1 b/dist/platforms/windows/build.ps1 index d6db87d5..9a0aec2c 100644 --- a/dist/platforms/windows/build.ps1 +++ b/dist/platforms/windows/build.ps1 @@ -116,6 +116,12 @@ Write-Output "" -customBuildTarget $Env:BUILD_TARGET ` -customBuildPath $Env:CUSTOM_BUILD_PATH ` -buildVersion $Env:VERSION ` + -androidVersionCode $Env:ANDROID_VERSION_CODE ` + -androidKeystoreName $Env:ANDROID_KEYSTORE_NAME ` + -androidKeystorePass $Env:ANDROID_KEYSTORE_PASS ` + -androidKeyaliasName $Env:ANDROID_KEYALIAS_NAME ` + -androidKeyaliasPass $Env:ANDROID_KEYALIAS_PASS ` + -androidTargetSdkVersion $Env:ANDROID_TARGET_SDK_VERSION ` $Env:CUSTOM_PARAMETERS ` -logfile | Out-Host