From 2c1b4030c8a79f217216ada2687d4050c10be9eb Mon Sep 17 00:00:00 2001 From: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com> Date: Sat, 16 Mar 2024 22:01:07 -0700 Subject: [PATCH] Remove version checking from image-tag --- dist/index.js | Bin 22303230 -> 22303007 bytes dist/index.js.map | Bin 14796913 -> 14796635 bytes src/model/image-tag.test.ts | 7 +------ src/model/image-tag.ts | 8 -------- 4 files changed, 1 insertion(+), 14 deletions(-) diff --git a/dist/index.js b/dist/index.js index 4e872ec8bb91cf8d2b13560513c81228310b1352..33531379c733305e507ff5629e4efb2570ba044b 100644 GIT binary patch delta 1454 zcmWmEXIl;c07l`fdMk=Zi>NdZErn<+D>Jh9-g_(AFCim)i|oB3JA1F}z4zWD#Cbm4 z=O>)p71>s4>DgAJjV4A@qgjR_H6hbE(U4-AoRegLIV@m_Jje?xSR)_u!v+OV5Vj}; zJJ`bkj&MR@6oE5}q8MD@3O5voJ3QbCFO)z@l!7-(qYQlD3qSZH0A&$~Ae2LSR6sB) zq7p(7iZFyD0+EP9Wke$eRZtbxP#rZ8i<+o~+NguNsE0VzM+3y8AsV4EnxH9~p*dQh zC0e01+Mq4kp*=dFBRZiox}Yn%p*wn@Cwieb`k*iRp+5#-AO>MDhF~a$ApwaPjwFo0 zNQ}a0jKNrpgAwB~0m+z%NtlcjOu3?3if{OiANYx1$iZ*?!C&O!UrJ7r$#f{DikV_i%oPj8 zQpuy_Rjd?iC7+UCu~7;r1r=MRkYcCUD-MdI;-nN-iYU%XQKgvTqPQwic(dnrc_sID6vXSrIu1#siV|Y>M3zbeWigCZ<57PObpll1L?OnmH+?% delta 1589 zcmXZcWmpvk6o>H#yo87-Dhh%MhIK;asAL7lQ07;LE5?%34L z9(KE_n}OZ28Jo44o9+95*oWWy>74WNEL~CH_Hku_+k|X~Y{%>(+YGrGM$15dV?f-n z#AI`q#AMSbb6UD3H6=dLYBi^&n5^b>tI?cfv8JZk7h7!J_A{aGp7xl|vt7OapY#t5 zvK0<=D_pfNi+1wK&&@F8INCjq7+jnSZ{;mN?d2EN#~2ZwkYtOLVHr&=8H#7%_-N6EsCL zG)D`xL@UIhHQJyp+MzuvQ!x!W zn2s5kiCM_SH~1ELn2kA@3p?gvJ{Djh7GW`#U@4YiIaXjLR$(>PU@gAG_gIJZ*nl7K zBQ|0aHe(C6VjH&OC*)%Xc48NHV-NOXANJz_4&o3F;|Px8XZ(U=IF1we6~EymPT@4p zpa5ra4(D+J7jX%faRpa#4cBo4H*pKMaRcZb~u5T`8`3C?%AV zil diff --git a/dist/index.js.map b/dist/index.js.map index 4de56fb12074b6d75133dcd2319068f9ae2276ae..e50af36bfdea210b88bd75f7a502a28201693ff7 100644 GIT binary patch delta 968 zcmWN=gLV}F007X_TCI9vakXr_wakUZW!tvaGG1h1?1j=ok>$e&q$HFIC65gcgnm^G?-lwJ6&46(9E}>1l8}&kCpOoL z^rT>VQWnF^YPi|VZiG3^X)XiiHjjDDXQcTpU_lF6*dj(*)M7?k+!B_wRAzco>8}?v z1NF+B3JXTZl(DSkEN=xXTFJ^*v8vUqZVhW%%i7kluJx>M17mDxtc`4J6Pw!1=C-h< zt!!-@+Zty(+uOm8#@orxcCoA7>~4ZR>}fB1+sD54v%doz=pY9>#GwvzxFa0tC`UWS zv5s@R6P)NICp*QdPIJ05oaroQJIA@sbG{2qbfHNuaN1zR!j-OawL#ao)^)CT zgB#uCW|K{Ei>ao$)oq5{?hbdl%iX5C$Gz@zzXv?%ArE`RqaO3PCp_sXPkY9*W_Zr? zUhtxqylkddyy`Wtd&8UF^0s%p>pk!Lz=uBau}^&JGoSmym%j3~Z+z=J-}}Lje)6+l W{OUKq`@^69^0$97qhtQ|OZ^WQ#Z$5X delta 1126 zcmY++`CrQc9LMp8#3;f@q~lu_8`(NW?i@MhTqNOJ8e18)SW~pkB+Qwz_`2^~C}Qq% z-$(A`{1f`kk6y(u{qX!eK9A4){rEJNx@ApeZdsMCs9YZ=Wy%8mJ@v^Ip1K4-DKXeL zw`HkS`KGi)lJF-eySFZ4z*`XB_M2=lre;SDt!bC#ft(B&GkO(}+Kb%Dv6Z_cym4K|y}YEj!v`8K7= zXtw29Q~xDWu`)a=N@poBu>uFaXW{XbgfH z8pI$LafpW&gE0gN7>Z#Sju9A%Q5cOxjKNrp!+0cN0w!V-CPRlQn2Kqbjv1HpfzIEhm@jWallb2yJmT);(KLKUiU8COt)tGEU)uHy!7;udb>4(_5B zb-0K7cz}m^gvWS-r+9|vc!8IAh1Yn4x2VTEyvGN8#3y{l7c}528u1O^@dH2c%PZIZ H)_MK{5tf2A diff --git a/src/model/image-tag.test.ts b/src/model/image-tag.test.ts index 47adf65e..a9241f2e 100644 --- a/src/model/image-tag.test.ts +++ b/src/model/image-tag.test.ts @@ -27,7 +27,7 @@ describe('ImageTag', () => { expect(image.builderPlatform).toStrictEqual(testImageParameters.builderPlatform); }); - test.each(['2000.0.0f0', '2011.1.11f1'])('accepts %p version format', (version) => { + test.each(['2000.0.0f0', '2011.1.11f1', '6000.0.0f1'])('accepts %p version format', (version) => { expect( () => new ImageTag({ @@ -37,11 +37,6 @@ describe('ImageTag', () => { ).not.toThrow(); }); - test.each(['some version', ''])('throws for incorrect version %p', (editorVersion) => { - const { targetPlatform } = testImageParameters; - expect(() => new ImageTag({ editorVersion, targetPlatform })).toThrow(); - }); - test.each(['nonExisting'])('throws for unsupported target %p', (targetPlatform) => { expect(() => new ImageTag({ targetPlatform })).toThrow(); }); diff --git a/src/model/image-tag.ts b/src/model/image-tag.ts index e32ccbdd..06f68d79 100644 --- a/src/model/image-tag.ts +++ b/src/model/image-tag.ts @@ -20,10 +20,6 @@ class ImageTag { providerStrategy, } = imageProperties; - if (!ImageTag.versionPattern.test(editorVersion)) { - throw new Error(`Invalid version "${editorVersion}".`); - } - // Todo we might as well skip this class for customImage. // Either this.customImage = customImage; @@ -41,10 +37,6 @@ class ImageTag { this.imageRollingVersion = Number(containerRegistryImageVersion); // Will automatically roll to the latest non-breaking version. } - static get versionPattern(): RegExp { - return /^(20\d{2}\.\d\.\w{3,4}|3)$/; - } - static get targetPlatformSuffixes() { return { generic: '',