From 9413908134a2f79658d40ff234e0f40e40a31e3f Mon Sep 17 00:00:00 2001 From: Andrew Kahr <22359829+AndrewKahr@users.noreply.github.com> Date: Mon, 27 Nov 2023 22:48:02 -0800 Subject: [PATCH] Update exit code name, set default exit code to -1 to make bugs obvious --- action.yml | 5 +++++ dist/index.js | Bin 22176637 -> 22176656 bytes dist/index.js.map | Bin 14647481 -> 14647500 bytes src/index.ts | 4 ++-- src/model/output.ts | 4 ++-- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/action.yml b/action.yml index 121174df..02b4d3f1 100644 --- a/action.yml +++ b/action.yml @@ -261,6 +261,11 @@ outputs: description: 'The generated version used for the Unity build' androidVersionCode: description: 'The generated versionCode used for the Android Unity build' + engineExitCode: + description: + 'Returns the exit code from the build scripts. This code is 0 if the build was successful. If there was an error + during activation, the code is from the activation step. If activation is successful, the code is from the project + build step.' branding: icon: 'box' color: 'gray-dark' diff --git a/dist/index.js b/dist/index.js index 21d73e1494b58eae57e04d87b6114894c487777e..b63cde657d8e434346273c5915f2f02ecb5a0541 100644 GIT binary patch delta 1498 zcmXBUS6mJN6o&C%`bvFYONBJ-QB-6UC9+3K_TI8(X781~qO5G$DfCVg(9agZ05hmEc7Iv_Q19HF-PH;v} zMwXo99_hURF2mS~06 zXoI$BhxX`zj_8EWh(s53MK^Ru5A;MY^hOl=pfCENKL%hRqA>`AF$6;~48t)3BQXl2 zF$QBX4&yNa6EO)fn2afyifNdR8JLM#n2kA@i&)IVe8eFh3$PH2uoz2_fTdW5xVVKxVDXx@IycHkCS1GBKQv8(CN*SfBQcm$#0+jMf1tm}kQYtFJN+qST5~5U5 nsw&l#>Piizrcz6(t<+KKDxpd}B}@rd>MIduhxsRF2?>7zK<0%+ delta 1489 zcmWmES6mGM0EO}2ty|r?N+mmm$X0ezDwI&!d&}M{n-DS+;S$+#b-?7g?_Eqj0G z;r~6Kr<0hT;qd2VhQrnvlV$24lR0UAvRjh#JZDR6g3;Zw#l>J_`4??tyW_0M)jBTI z9G_`6zzWuTGR?;8`z)zx#xn6)X-3$<7IrYf9u6=g8yw+;>~Mw)T#*BA$cbFYjXcPU ze8>-X6o3ajQ4obt7+xrXqVPsB6h{e^L@AVpc9w+?d{GYNQ2`ZE36)U=ey9q6R6_s) zQ5``DMhI%4CTbxRVW^F8)InX;Lj)obh5BfKhG>MwXo99_hURF2mS~06XoI$BhxX`z zj_8DFbVe6+MK^Ru5A;MY^hO`_ML+b%01U(+3`PuwU?_%RI7VP3MqxC@AQodW4&xDr z37CjUh{t41!BkAcbj&~kW+D-@FdIpjgSnUo3+7`1lCcnrkb=cnf~8o7a#EF&xJUq~RpeaS9nY zjWallb2yI+xQI)*j4QZ`Yq*XZxQSc1jXSuDd$^AWc!)=Mj3>y%Q#`|SyueGm!fU+2 zTfD=2e85M1LKZ&b3%=qTzT*de;un775B}ocw5&A4Oej{0wPI9k6kEkkF)8+ngJM>) zDUOPhl3j6DTohL&hvKH>RB|b~l{`vbC7+UCaaRf`9*U<@P${GoR=kuVN>RmIDW()x zN+>0jQc7v1j8azdQGAthN_nM%QcBQKTxaWX%}uuGrIU z_B4mnVnk>7ql?RFG3EdK-}ErEsu}*xMmwx#6#?jqZs?9c^ne*b2u28cq8CEZ8+{N4 z4Sf*~3;Lly24EltVK9bZD28D;Mj!%_7>Ov1!rx!f7=y7Ghw+HP1Wd#vOvV(%Vk)K~ z4%0CMGZBvjBw`k3V-Dsb3CXZx9#W8sG|WdjGGN03EW{!#h8;_=6w8o_EG)+gti&p; z#u}`}I;_VAY{VvHBL}(I48ay`g#&rmhV9saeC)(7?8YAK#XjuE0UX33=s1icC_o{O z;uwzO1d4DHr%;R%IB^TKMkC(fE#BchKHwuh;WNJAtIKNs7N773 DH1A$9 delta 901 zcmWm6=XVWu007Wq#H`t%^^m7Us8P|_#7^xFO3WIyH?dd3k01@L^~_EUT50Xrv-aMb ze<8;?zB;ZC_v^i$`L@_mGD4wHI1~v*LtH2piiZ-RWGEF%hYv!TP&Skc}Nax diff --git a/src/index.ts b/src/index.ts index 9e11f34c..89db2de3 100644 --- a/src/index.ts +++ b/src/index.ts @@ -19,7 +19,7 @@ async function runMain() { const buildParameters = await BuildParameters.create(); const baseImage = new ImageTag(buildParameters); - let exitCode = 0; + let exitCode = -1; if (buildParameters.providerStrategy === 'local') { core.info('Building locally'); @@ -39,7 +39,7 @@ async function runMain() { // Set output await Output.setBuildVersion(buildParameters.buildVersion); await Output.setAndroidVersionCode(buildParameters.androidVersionCode); - await Output.setExitCode(exitCode); + await Output.setEngineExitCode(exitCode); if (exitCode !== 0) { core.setFailed(`Build failed with exit code ${exitCode}`); diff --git a/src/model/output.ts b/src/model/output.ts index 2169e3b2..440bb68e 100644 --- a/src/model/output.ts +++ b/src/model/output.ts @@ -9,8 +9,8 @@ class Output { core.setOutput('androidVersionCode', androidVersionCode); } - static async setExitCode(exitCode: number) { - core.setOutput('exitCode', exitCode); + static async setEngineExitCode(exitCode: number) { + core.setOutput('engineExitCode', exitCode); } }