From b66dffbf925438cfaa76a27d8dc2a074a76ec104 Mon Sep 17 00:00:00 2001
From: David Finol <davidmfinol@gmail.com>
Date: Thu, 1 Jul 2021 06:38:44 -0500
Subject: [PATCH] Projectpath error message (#274)

* Improve error message

* Improve error message
---
 dist/index.js                      | Bin 14729234 -> 14729468 bytes
 dist/index.js.map                  | Bin 8949027 -> 8949317 bytes
 src/model/unity-versioning.test.ts |   4 ++--
 src/model/unity-versioning.ts      |   4 +---
 4 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/dist/index.js b/dist/index.js
index 2f39fc8b76b6e08cd4f909e9915405505348f9bc..80b952b988b1c9a680c2c1253fc548d7bc96a5f9 100644
GIT binary patch
delta 1242
zcmYk)S5p*06o%ni!=ivFB8r$APyqu5%wj-A%%Wn#0JF=$F0wPj>;Pf}SH&#GG3T5E
zy5^iS<}CgIZ@jh&-&HT{s;8>!bbo#N;;b$9`28yJ_!XC1DqY?%#bT>wHjhmTPD|0%
z9NBINw`>?rCEG2soVl`4R6}H``AVjc3=!FKwy&5X8IHM;abk#6Ad4b3U)WV$Cz@O2
z3k$;`3+?Y?zMK6r){Th|F;jF)Kxvg`K{ZrI4b+4ceyD}o@Q3eiAnG6pbx{w&sE-gd
zKqwlb5yH?I;b?-UXolu!0f7iaA_^_h3at^17{sCt+M*rWBMu$V5uMN(@#uoC=!Wj-
zfu87v-bg?n^hH1PM<NDbAO;}`gOQ9O7>Z#Sju9A%Q5cOBjKNrpLn_8&0w!V-CL;|~
zFcs4<9qGt`1RLzggp4d?!vQC9Fax=8L4gVldEP2b-)RkTYq?G%Cc0g8Y@AEdVhr8s
z^0o-Dr&_$$B0a+2{Nb|uS;xvQwLmt%N2P~0WuA1^C2XqU5VDf#7HXD|gqxs}ZJv&>
zg$1z}sm#v5T14Q423C<M6uHnWyOS3>DuaWJKc|`|XZrGm4yPfzHOVgfi#Ecy><&qn
z?1rrW-_B{cg-y<ODhj=X#4PgxvqHCp*YN$@EKW@h{j)0-9vyBN$VUMRF%w0Yh1r;c
zxtNFfC`Jhuz=MTYgvBVu5-i0sEXNA0#44;t8P;Ge)?qz1U?WUy!e(s2R&2v|?7&X!
z!fx!rUhKnu9Kb;w!eJc2Q5?f@oWMz(!fBkrS(M`(&cllfxQI)*j4QZ`Yq*XZxQSc1
zjXSuDd$^AWc!)=Mj3;=CXLybmsK86S!fU+2TfD=2e85M1!e@NJSA6pdPvy^q-$)2O
Al>h($

delta 1038
zcmWm8`CE$t0KoBQXsc1km0a((h~yZ#8<G2r$W7C>Hm!HFHp;|mWA39DbKf`36|W<?
zk8&hea`yNK`~!aQ?T63ve1H7@EAgw!e14U$LeZEnmCI35tzIuB)uc$(F$OtPRQy#)
zY0(j(Dw878ke%-E*iC}ya0?cjXcDvuUW?6c&M>;I#oA;c&un(u#9YB6+T2B1W><mD
zAqvI<L2LB59a>2fAE!)g%EVyUsX#L{M+-zi2^As{1vOft6`~P?)@Xyah($ZJM+bC7
zC&ZyM;?V_N(GA_v0|GSALWczOL@zYG^+q2gp)Zor5B)I!1EI$t3`PouU?_%RI7VP3
zMj;gjjK&zGVJyZW9pf<p6EO*sF$GgG4bw3LGcgMpn2kBe#9Yin7Up9C7Ge<=V+odG
z8I~g(Myx;%OfbWOTv%blO60+ge28$siB)pg>8e!9_39j}Lar-xY1AR_A6INp7jU5f
zZg{X7Yfy+Htc4frP>l8103S+F3O@qah)oD$GqzwWwqZMVU?+BAH};?m682&r_9KJ?
zIEX_yj3YRTV>pfzIEhm@jWallb2yI+xQI)*j4LQd7*}x(*Kq?kQGr{y4H<WE7x!=<
zm3V+EJj5eB#uGfnGd#x&yu>S1qXw_>25<2WwRn#@e85M1!e@LzJ-(s=-|!tj@DsoA
LTh;{{8&dxRd1ls5

diff --git a/dist/index.js.map b/dist/index.js.map
index 24ccab553976554650a359283c59742fb4e7d557..29d28ca3ee711f0f184ddbe0fa8cbee12da2780e 100644
GIT binary patch
delta 970
zcmZwFOHUI~6u|Mc7UZE|MG!^gT2acwswfJIA_9u|pdcb>!4B=T9c*VxI|a)_K+z`d
zanKk87*_@j#-yLXwI<>RVDE;NiEjLlEZjKBFS+;JIp^G)oHs9*ZJ%E)+h*o0pR8r`
z>Hc}^h}F;<+wC5AOdFPcx`@lVuBgGd2q<A$sG2SUT0->;Nf#bR`GgsDOL}O^<8X;~
zX;c<TEg^hbEJkuTX{HN3B#Y=~IrG;huQ6M1aTxEPTX&?C1uM3|h74q4E3%M{9OPmf
zwj&SuFmvtLi303GA&RgY#n^+rD8W9IVn50tZ~zV*L^%%OFe>0gC8|)38XSQOM{x|t
zQHv8ei8`FZY1E?uXK)scIEV9S!UZ(rB3jUjHeAAGwBrgoa23~Z9XHSkH@eV`o9MwU
z^x`)9(2qN~3l9b`h<ort!VrA$Lq-5WgrHy;_Yp<}Dl|kff*9h^)5=2Pbyh(<8dh{?
zMNLJeD<VamdQ6F=OO_Hpa}6y&kki;LM>M8nETrgiJSzEQ;R{JI$*0RPW-O*f#E_<k
zgsl4GLJJ5<#HpYLT^?0b8LKUU!aM?^hmqPmFg9Kc6lF9ERUR|!)pB8{m$>)uVKgfH
z%^LrDnMH*8{kNy0$HkBwR8*CQLSo3dg|TWKEw!1iFuH#97iF3&XQi?9wxihiFrDa2
zO|B#`iZMJ$Pp%{_!dU#C%rd_8&eU$M2A|EfrN6Exe`T2a?38^iiE&I|5>t4HY0O|2
nkMJ0Cc#^iSJ^lFGh!&(;Ee*y-ZmKiASTbH`PrKJs-`@QJ;q#WO

delta 736
zcmWm4O;6Ks0D$qd&M~H_fQkazI+6Lpi})_S&fzPlpn{51n68CNZ3k=B4Uyr1eggax
z<AIFCi^;qY`w7&83GwV{@e_FS>cio8dGdVwSPU$GC<gMg(u%Ash}CAP(^nScaapwf
zkgH<DaoaUhs%1N>ZdfTb5owy#4O8n)I-^sGNQ*kAX=%e6QC-V$vIE*g#;`3lnPE)2
zj-7~znH9NKq`RbwV05iS#ounJUM%%U6`ryvV;urmk09212$cw912&=xo3I&MP>mYY
zVk@>`JL<3lJ5i4YG-4NaLxGAth+r?8un*0MVm}VxAP%7gt!P6#4x<A{a1_UI94BxR
zr*ImbID@k|hx53Ai-_S8;^@L<T)|ab!*$$1H+parw{RQ1=))b{#Xa<60Qd0#4>5>G
zNZ>J^U<kuV;whdX1r0hzFbV_DF$NPaV8KQj<Cs7Oj;}1brI7zGsJoIME4uH);&+W6
z7oVoxsAra3yu>TK_RUgOQboC(4U46Qxk}-FEp&)-e?H`WS<NDcNxZ=n-eMYg%-|gg
gn8h6Cef7I1%d$D>_ci7U)#BICe8|uJ@qT{(4-9oAg8%>k

diff --git a/src/model/unity-versioning.test.ts b/src/model/unity-versioning.test.ts
index 7a87393a..94aa3c6a 100644
--- a/src/model/unity-versioning.test.ts
+++ b/src/model/unity-versioning.test.ts
@@ -14,8 +14,8 @@ describe('Unity Versioning', () => {
   });
 
   describe('read', () => {
-    it('does not throw', () => {
-      expect(() => UnityVersioning.read('')).not.toThrow();
+    it('throws for invalid path', () => {
+      expect(() => UnityVersioning.read('')).toThrow(Error);
     });
 
     it('reads from test-project', () => {
diff --git a/src/model/unity-versioning.ts b/src/model/unity-versioning.ts
index 7b98e0ab..6bf07081 100644
--- a/src/model/unity-versioning.ts
+++ b/src/model/unity-versioning.ts
@@ -1,4 +1,3 @@
-import * as core from '@actions/core';
 import * as fs from 'fs';
 import path from 'path';
 
@@ -17,8 +16,7 @@ export default class UnityVersioning {
   static read(projectPath) {
     const filePath = path.join(projectPath, 'ProjectSettings', 'ProjectVersion.txt');
     if (!fs.existsSync(filePath)) {
-      core.warning(`Could not find "${filePath}", keeping unityVersion as "auto"`);
-      return 'auto';
+      throw new Error(`Project settings file not found at "${filePath}". Have you correctly set the projectPath?`);
     }
     return UnityVersioning.parse(fs.readFileSync(filePath, 'utf8'));
   }