EthanPisani/unity-builder
1
0
Fork 0
mirror of https://github.com/game-ci/unity-builder.git synced 2025-07-07 20:35:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

cleanup async parameter

Browse Source
This commit is contained in:
Frostebite 2023-11-18 17:16:26 +00:00
parent df4cc41418
commit e296ef2dc1
6 changed files with 15 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
.eslintrc.json
View File

@ -1,22 +1,11 @@
{ {
"plugins": [ "plugins": ["jest", "@typescript-eslint", "prettier", "unicorn"],
"jest", "extends": ["plugin:unicorn/recommended", "plugin:github/recommended", "plugin:prettier/recommended"],
"@typescript-eslint",
"prettier",
"unicorn"
],
"extends": [
"plugin:unicorn/recommended",
"plugin:github/recommended",
"plugin:prettier/recommended"
],
"parser": "@typescript-eslint/parser", "parser": "@typescript-eslint/parser",
"parserOptions": { "parserOptions": {
"ecmaVersion": 2020, "ecmaVersion": 2020,
"sourceType": "module", "sourceType": "module",
"extraFileExtensions": [ "extraFileExtensions": [".mjs"],
".mjs"
],
"ecmaFeatures": { "ecmaFeatures": {
"impliedStrict": true "impliedStrict": true
}, },
@ -33,10 +22,7 @@
// Namespaces or sometimes needed // Namespaces or sometimes needed
"import/no-namespace": "off", "import/no-namespace": "off",
// Properly format comments // Properly format comments
"spaced-comment": [ "spaced-comment": ["error", "always"],
"error",
"always"
],
"lines-around-comment": [ "lines-around-comment": [
"error", "error",
{ {
@ -71,12 +57,7 @@
// Enforce camelCase // Enforce camelCase
"camelcase": "error", "camelcase": "error",
// Allow forOfStatements // Allow forOfStatements
"no-restricted-syntax": [ "no-restricted-syntax": ["error", "ForInStatement", "LabeledStatement", "WithStatement"],
"error",
"ForInStatement",
"LabeledStatement",
"WithStatement"
],
// Continue is viable in forOf loops in generators // Continue is viable in forOf loops in generators
"no-continue": "off", "no-continue": "off",
// From experience, named exports are almost always desired. I got tired of this rule // From experience, named exports are almost always desired. I got tired of this rule

BIN
dist/index.js generated vendored
View File

Binary file not shown.

BIN
dist/index.js.map generated vendored
View File

Binary file not shown.

4
src/model/cloud-runner/tests/cloud-runner-github-checks.test.ts
View File

@ -39,11 +39,11 @@ describe('Cloud Runner Github Checks', () => {
asyncCloudRunner: `true`, asyncCloudRunner: `true`,
githubChecks: `true`, githubChecks: `true`,
}); });
GitHub.asyncWorkflows = true; GitHub.forceAsyncTest = true;
await CloudRunner.setup(buildParameter); await CloudRunner.setup(buildParameter);
CloudRunner.buildParameters.githubCheckId = await GitHub.createGitHubCheck(`t`); CloudRunner.buildParameters.githubCheckId = await GitHub.createGitHubCheck(`t`);
await GitHub.updateGitHubCheck(`t`, `t2`); await GitHub.updateGitHubCheck(`t`, `t2`);
GitHub.asyncWorkflows = false; GitHub.forceAsyncTest = false;
}, 1_000_000_000); }, 1_000_000_000);
} }
}); });

4
src/model/github.ts
View File

@ -11,7 +11,7 @@ class GitHub {
private static startedDate: string; private static startedDate: string;
private static endedDate: string; private static endedDate: string;
static result: string = ``; static result: string = ``;
static asyncWorkflows: boolean; static forceAsyncTest: boolean;
private static get octokitDefaultToken() { private static get octokitDefaultToken() {
return new Octokit({ return new Octokit({
auth: process.env.GITHUB_TOKEN, auth: process.env.GITHUB_TOKEN,
@ -128,7 +128,7 @@ class GitHub {
data.conclusion = result; data.conclusion = result;
} }
await (CloudRunner.isCloudRunnerAsyncEnvironment || GitHub.asyncWorkflows await (CloudRunner.isCloudRunnerAsyncEnvironment || GitHub.forceAsyncTest
? GitHub.runUpdateAsyncChecksWorkflow(data, `update`) ? GitHub.runUpdateAsyncChecksWorkflow(data, `update`)
: GitHub.updateGitHubCheckRequest(data)); : GitHub.updateGitHubCheckRequest(data));
} }

12
test-project/ProjectSettings/Packages/com.unity.testtools.codecoverage/Settings.json
View File

@ -1,7 +1,7 @@
{ {
"m_Name": "Settings", "m_Name": "Settings",
"m_Path": "ProjectSettings/Packages/com.unity.testtools.codecoverage/Settings.json", "m_Path": "ProjectSettings/Packages/com.unity.testtools.codecoverage/Settings.json",
"m_Dictionary": { "m_Dictionary": {
"m_DictionaryValues": [] "m_DictionaryValues": []
} }
} }